Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: media/video/capture/android/video_capture_device_android.cc

Issue 311343004: VideoCaptureDevice: remove emtpy static methods that are now implemented in the VCDFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/video/capture/linux/video_capture_device_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/android/video_capture_device_android.cc
diff --git a/media/video/capture/android/video_capture_device_android.cc b/media/video/capture/android/video_capture_device_android.cc
index 6fba8d35047c4324176f5fddfe9f377dafe3cf3b..d445412ca8eda2d21c0c21d330123e40c6e84784 100644
--- a/media/video/capture/android/video_capture_device_android.cc
+++ b/media/video/capture/android/video_capture_device_android.cc
@@ -26,30 +26,6 @@ bool VideoCaptureDeviceAndroid::RegisterVideoCaptureDevice(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-// TODO(mcasas): Remove the following static methods when they are no longer
-// referenced from VideoCaptureDeviceFactory, i.e. when all OS platforms have
-// splitted the VideoCaptureDevice into VideoCaptureDevice and
-// VideoCaptureDeviceFactory.
-
-// static
-VideoCaptureDevice* VideoCaptureDevice::Create(
- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
- const Name& device_name) {
- NOTREACHED();
- return NULL;
-}
-// static
-void VideoCaptureDevice::GetDeviceNames(Names* device_names) {
- NOTREACHED();
-}
-
-// static
-void VideoCaptureDevice::GetDeviceSupportedFormats(
- const Name& device,
- VideoCaptureFormats* supported_formats) {
- NOTREACHED();
-}
-
const std::string VideoCaptureDevice::Name::GetModel() const {
// Android cameras are not typically USB devices, and this method is currently
// only used for USB model identifiers, so this implementation just indicates
« no previous file with comments | « no previous file | media/video/capture/linux/video_capture_device_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698