Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 311313006: Fix some MSE tests on devices that don't support VP9 (Closed)

Created:
6 years, 6 months ago by qinmin
Modified:
6 years, 6 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Visibility:
Public.

Description

Fix some MSE tests on devices that doesn't support VP9 Some devices don't support VP9, so we cannot use VP9 to simulate config changes. Instead, pass VP8 and a different resolution to work around the issue. BUG=381208 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275287

Patch Set 1 #

Patch Set 2 : removing the codec input param since it is always vp8 #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M media/base/android/media_source_player_unittest.cc View 1 2 9 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qinmin
PTAL
6 years, 6 months ago (2014-06-05 18:59:41 UTC) #1
wolenetz
lgtm % nit https://codereview.chromium.org/311313006/diff/20001/media/base/android/media_source_player_unittest.cc File media/base/android/media_source_player_unittest.cc (right): https://codereview.chromium.org/311313006/diff/20001/media/base/android/media_source_player_unittest.cc#newcode288 media/base/android/media_source_player_unittest.cc:288: DemuxerConfigs CreateVideoDemuxerConfigs(const gfx::Size& size) { nit: ...
6 years, 6 months ago (2014-06-05 20:06:48 UTC) #2
wolenetz
On 2014/06/05 20:06:48, wolenetz wrote: > lgtm % nit > > https://codereview.chromium.org/311313006/diff/20001/media/base/android/media_source_player_unittest.cc > File media/base/android/media_source_player_unittest.cc ...
6 years, 6 months ago (2014-06-05 20:07:08 UTC) #3
qinmin
https://codereview.chromium.org/311313006/diff/20001/media/base/android/media_source_player_unittest.cc File media/base/android/media_source_player_unittest.cc (right): https://codereview.chromium.org/311313006/diff/20001/media/base/android/media_source_player_unittest.cc#newcode288 media/base/android/media_source_player_unittest.cc:288: DemuxerConfigs CreateVideoDemuxerConfigs(const gfx::Size& size) { On 2014/06/05 20:06:47, wolenetz ...
6 years, 6 months ago (2014-06-05 20:42:12 UTC) #4
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 6 months ago (2014-06-05 20:42:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/311313006/40001
6 years, 6 months ago (2014-06-05 20:44:20 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:09:00 UTC) #7
Message was sent while issue was closed.
Change committed as 275287

Powered by Google App Engine
This is Rietveld 408576698