Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: content/browser/browser_main_loop.h

Issue 311313005: Add --trace-rotate-startup-file option and store unsaved trace data on exit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicit BrowserShutdownProfileDumper. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_loop.h
diff --git a/content/browser/browser_main_loop.h b/content/browser/browser_main_loop.h
index f38ac4234abbdbfad5c8de485aa45068eaca74c6..72d38de1682ab9481a7f3bf70a49cdfc5725178e 100644
--- a/content/browser/browser_main_loop.h
+++ b/content/browser/browser_main_loop.h
@@ -6,8 +6,10 @@
#define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
#include "base/basictypes.h"
+#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/timer/timer.h"
#include "content/browser/browser_process_sub_thread.h"
#include "content/public/browser/browser_main_runner.h"
@@ -104,6 +106,12 @@ class CONTENT_EXPORT BrowserMainLoop {
bool is_tracing_startup() const { return is_tracing_startup_; }
+ const base::FilePath& startup_trace_file() const {
+ return startup_trace_file_;
+ }
+
+ void StopStartupTracingTimer();
+
#if defined(OS_MACOSX) && !defined(OS_IOS)
DeviceMonitorMac* device_monitor_mac() const {
return device_monitor_mac_.get();
@@ -131,7 +139,7 @@ class CONTENT_EXPORT BrowserMainLoop {
void MainMessageLoopRun();
void InitStartupTracing(const base::CommandLine& command_line);
- void EndStartupTracing(const base::FilePath& trace_file);
+ void EndStartupTracing();
// Members initialized on construction ---------------------------------------
const MainFunctionParams& parameters_;
@@ -190,6 +198,10 @@ class CONTENT_EXPORT BrowserMainLoop {
scoped_ptr<base::debug::TraceEventSystemStatsMonitor> system_stats_monitor_;
bool is_tracing_startup_;
+ base::FilePath startup_trace_file_;
+
+ // This timer initiates trace file saving.
+ base::OneShotTimer<BrowserMainLoop> startup_trace_timer_;
DISALLOW_COPY_AND_ASSIGN(BrowserMainLoop);
};

Powered by Google App Engine
This is Rietveld 408576698