Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: PRESUBMIT.py

Issue 311313005: Add --trace-rotate-startup-file option and store unsaved trace data on exit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicit BrowserShutdownProfileDumper. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 'ScopedAllowIO', 161 'ScopedAllowIO',
162 ( 162 (
163 'New code should not use ScopedAllowIO. Post a task to the blocking', 163 'New code should not use ScopedAllowIO. Post a task to the blocking',
164 'pool or the FILE thread instead.', 164 'pool or the FILE thread instead.',
165 ), 165 ),
166 True, 166 True,
167 ( 167 (
168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$", 168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$",
169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
171 r"^content[\\\/]browser[\\\/]tracing[\\\/]add_new_file_index\.cc$",
171 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", 172 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$",
172 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 173 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
173 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 174 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
174 ), 175 ),
175 ), 176 ),
176 ( 177 (
177 'SkRefPtr', 178 'SkRefPtr',
178 ( 179 (
179 'The use of SkRefPtr is prohibited. ', 180 'The use of SkRefPtr is prohibited. ',
180 'Please use skia::RefPtr instead.' 181 'Please use skia::RefPtr instead.'
(...skipping 1474 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 builders.extend(['cros_x86']) 1656 builders.extend(['cros_x86'])
1656 1657
1657 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1658 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1658 # unless they're .gyp(i) files as changes to those files can break the gyp 1659 # unless they're .gyp(i) files as changes to those files can break the gyp
1659 # step on that bot. 1660 # step on that bot.
1660 if (not all(re.search('^chrome', f) for f in files) or 1661 if (not all(re.search('^chrome', f) for f in files) or
1661 any(re.search('\.gypi?$', f) for f in files)): 1662 any(re.search('\.gypi?$', f) for f in files)):
1662 builders.extend(['android_aosp']) 1663 builders.extend(['android_aosp'])
1663 1664
1664 return GetDefaultTryConfigs(builders) 1665 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_main_loop.h » ('j') | content/browser/tracing/add_new_file_index.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698