Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 311313005: Add --trace-rotate-startup-file option and store unsaved trace data on exit. (Closed)

Created:
6 years, 6 months ago by Alexander Alekseev
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam, Nikita (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add --trace-rotate-startup-file option and store unsaved trace data on exit. This CL enables chromeos chrome startup trace when chrome in restarted on user log in: 1) --trace-rotate-startup-file created new trace file on restart so that previous is not ovewritten. 2) startup trace would be saved to disk on process exit if "trace-startup-duration" period has not ended yet. BUG=346913 TEST=manual

Patch Set 1 #

Total comments: 2

Patch Set 2 : explicit BrowserShutdownProfileDumper. #

Total comments: 2

Patch Set 3 : Init startup trace file name before thred restrictions are turned on. #

Patch Set 4 : No PRESUBMIT.py modifications is nesessary. #

Patch Set 5 : Fix windows build. #

Patch Set 6 : Fix windows build. #

Patch Set 7 : Fix windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -43 lines) Patch
M content/browser/browser_main_loop.h View 1 2 4 chunks +15 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 6 chunks +26 lines, -11 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +26 lines, -3 lines 0 comments Download
M content/browser/browser_shutdown_profile_dumper.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 4 chunks +12 lines, -22 lines 0 comments Download
A content/browser/tracing/add_new_file_index.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A content/browser/tracing/add_new_file_index.cc View 1 2 3 4 5 6 1 chunk +27 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Alekseev
Chrome on ChromeOS is sometimes restarted (on user log on, for example) and startup trace ...
6 years, 6 months ago (2014-06-05 16:04:55 UTC) #1
sky
LGTM https://codereview.chromium.org/311313005/diff/1/content/browser/browser_shutdown_profile_dumper.h File content/browser/browser_shutdown_profile_dumper.h (right): https://codereview.chromium.org/311313005/diff/1/content/browser/browser_shutdown_profile_dumper.h#newcode33 content/browser/browser_shutdown_profile_dumper.h:33: BrowserShutdownProfileDumper(const base::FilePath& dump_file_name); explicit
6 years, 6 months ago (2014-06-05 18:09:05 UTC) #2
Alexander Alekseev
https://codereview.chromium.org/311313005/diff/1/content/browser/browser_shutdown_profile_dumper.h File content/browser/browser_shutdown_profile_dumper.h (right): https://codereview.chromium.org/311313005/diff/1/content/browser/browser_shutdown_profile_dumper.h#newcode33 content/browser/browser_shutdown_profile_dumper.h:33: BrowserShutdownProfileDumper(const base::FilePath& dump_file_name); On 2014/06/05 18:09:05, sky wrote: > ...
6 years, 6 months ago (2014-06-05 21:12:06 UTC) #3
jochen (gone - plz use gerrit)
content/public lgtm, but please try to avoid using scoped allow io https://codereview.chromium.org/311313005/diff/20001/content/browser/tracing/add_new_file_index.cc File content/browser/tracing/add_new_file_index.cc (right): ...
6 years, 6 months ago (2014-06-06 07:01:50 UTC) #4
Alexander Alekseev
https://codereview.chromium.org/311313005/diff/20001/content/browser/tracing/add_new_file_index.cc File content/browser/tracing/add_new_file_index.cc (right): https://codereview.chromium.org/311313005/diff/20001/content/browser/tracing/add_new_file_index.cc#newcode15 content/browser/tracing/add_new_file_index.cc:15: base::ThreadRestrictions::ScopedAllowIO allow_io; On 2014/06/06 07:01:49, jochen traveling until Jun ...
6 years, 6 months ago (2014-06-06 15:43:41 UTC) #5
nduca
6 years, 6 months ago (2014-06-09 20:21:06 UTC) #6 
this is two changes. please break them up into two changelists.

Powered by Google App Engine
This is Rietveld 408576698