Convert SerialDeviceInfo to a Mojo struct.

Convert SerialDeviceInfo to a Mojo struct.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277921

[darin (slow to review), 2014-06-16 16:59:19]

Nice.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_linux.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_linux.cc:77: info->path =
mojo::String::From(path);
In this case, since you are converting from |const char*|, you could just use
the mojo::String::operator=(const char*) method.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_linux.cc:96: info->display_name =
mojo::String::From(product_name);
ditto

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_mac.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_mac.cc:51: info->path =
mojo::String::From(next_device);
use of mojo::String::From here is unnecessary. you can just assign a std::string
to a mojo::String.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_win.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_win.cc:35: info->path =
mojo::String::From(base::UTF16ToASCII(iter_key.Value()));
nit: mojo::String::From(..) is unnecessary here

[Sam McNally, 2014-06-17 07:07:20]

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_linux.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_linux.cc:77: info->path =
mojo::String::From(path);
On 2014/06/16 16:59:19, darin wrote:
> In this case, since you are converting from |const char*|, you could just use
> the mojo::String::operator=(const char*) method.

Done.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_linux.cc:96: info->display_name =
mojo::String::From(product_name);
On 2014/06/16 16:59:19, darin wrote:
> ditto

Done.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_mac.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_mac.cc:51: info->path =
mojo::String::From(next_device);
On 2014/06/16 16:59:19, darin wrote:
> use of mojo::String::From here is unnecessary. you can just assign a
std::string
> to a mojo::String.

Done.

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
File device/serial/serial_device_enumerator_win.cc (right):

https://codereview.chromium.org/311313002/diff/130001/device/serial/serial_de...
device/serial/serial_device_enumerator_win.cc:35: info->path =
mojo::String::From(base::UTF16ToASCII(iter_key.Value()));
On 2014/06/16 16:59:19, darin wrote:
> nit: mojo::String::From(..) is unnecessary here

Done.

[darin (slow to review), 2014-06-17 07:17:26]

LGTM

[Ken Rockot(use gerrit already), 2014-06-17 13:49:57]

Nice. LGTM.

[Sam McNally, 2014-06-17 23:26:31]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-06-17 23:30:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/311313002/150001

[commit-bot: I haz the power, 2014-06-18 00:22:01]

Change committed as 277921