Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8174)

Unified Diff: chrome/browser/web_applications/web_app.cc

Issue 311293002: Ensure ephemeral apps have dock icons on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app.cc
diff --git a/chrome/browser/web_applications/web_app.cc b/chrome/browser/web_applications/web_app.cc
index 5397c1dc0be51039032afca514a3ee3908276404..875d30eb98a6e30ecc77a3e4815445ac120e90e3 100644
--- a/chrome/browser/web_applications/web_app.cc
+++ b/chrome/browser/web_applications/web_app.cc
@@ -237,11 +237,8 @@ ShortcutInfo::~ShortcutInfo() {}
ShortcutLocations::ShortcutLocations()
: on_desktop(false),
applications_menu_location(APP_MENU_LOCATION_NONE),
- in_quick_launch_bar(false)
-#if defined(OS_POSIX)
- , hidden(false)
-#endif
- {
+ in_quick_launch_bar(false),
+ hidden(false) {
}
void GetShortcutInfoForTab(content::WebContents* web_contents,
@@ -298,8 +295,9 @@ void UpdateShortcutInfoAndIconForApp(const extensions::Extension* extension,
bool ShouldCreateShortcutFor(Profile* profile,
const extensions::Extension* extension) {
return extension->is_platform_app() &&
- extension->location() != extensions::Manifest::COMPONENT &&
- extensions::ui_util::ShouldDisplayInAppLauncher(extension, profile);
+ extension->location() != extensions::Manifest::COMPONENT &&
+ extensions::ui_util::ShouldDisplayInAppLauncherIncludingEphemeral(
+ extension, profile);
}
base::FilePath GetWebAppDataDirectory(const base::FilePath& profile_path,

Powered by Google App Engine
This is Rietveld 408576698