Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/browser/extensions/extension_ui_util.cc

Issue 311293002: Ensure ephemeral apps have dock icons on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_ui_util.cc
diff --git a/chrome/browser/extensions/extension_ui_util.cc b/chrome/browser/extensions/extension_ui_util.cc
index ab8c5ac0a717f94934042b769f01546b40264cef..33af4226b47ef8ec80f71445d43edb8d1cb3bc71 100644
--- a/chrome/browser/extensions/extension_ui_util.cc
+++ b/chrome/browser/extensions/extension_ui_util.cc
@@ -30,9 +30,15 @@ namespace ui_util {
bool ShouldDisplayInAppLauncher(const Extension* extension,
content::BrowserContext* context) {
+ return ShouldDisplayInAppLauncherIncludingEphemeral(extension, context) &&
+ !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldDisplayInAppLauncherIncludingEphemeral(
+ const Extension* extension,
+ content::BrowserContext* context) {
return extension->ShouldDisplayInAppLauncher() &&
- !IsBlockedByPolicy(extension, context) &&
- !util::IsEphemeralApp(extension->id(), context);
+ !IsBlockedByPolicy(extension, context);
}
bool ShouldDisplayInNewTabPage(const Extension* extension,

Powered by Google App Engine
This is Rietveld 408576698