Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/extensions/extension_ui_util.h

Issue 311293002: Ensure ephemeral apps have dock icons on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserContext; 9 class BrowserContext;
10 } 10 }
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 class Extension; 14 class Extension;
15 15
16 namespace ui_util { 16 namespace ui_util {
17 17
18 // Returns true if the extension should be displayed in the app launcher. 18 // Returns true if the extension should be displayed in the app launcher.
19 // Checks whether the extension is an ephemeral app or should be hidden due to 19 // Checks whether the extension is an ephemeral app or should be hidden due to
20 // policy. 20 // policy.
21 bool ShouldDisplayInAppLauncher(const Extension* extension, 21 bool ShouldDisplayInAppLauncher(const Extension* extension,
22 content::BrowserContext* context); 22 content::BrowserContext* context);
23 23
24 // Returns true if the extension should be displayed in the app launcher.
25 // Checks whether the extension should be hidden due to policy, but does not
26 // exclude ephemeral apps.
27 bool ShouldDisplayInAppLauncherIncludingEphemeral(
benwells 2014/06/05 09:27:43 This needs a better name. How about CanDisplayInAp
tmdiep 2014/06/06 02:49:55 Done.
28 const Extension* extension,
29 content::BrowserContext* context);
30
24 // Returns true if the extension should be displayed in the browser NTP. 31 // Returns true if the extension should be displayed in the browser NTP.
25 // Checks whether the extension is an ephemeral app or should be hidden due to 32 // Checks whether the extension is an ephemeral app or should be hidden due to
26 // policy. 33 // policy.
27 bool ShouldDisplayInNewTabPage(const Extension* extension, 34 bool ShouldDisplayInNewTabPage(const Extension* extension,
28 content::BrowserContext* context); 35 content::BrowserContext* context);
29 36
30 // Returns true if the extension should be displayed in the extension 37 // Returns true if the extension should be displayed in the extension
31 // settings page (i.e. chrome://extensions). Checks whether the extension is 38 // settings page (i.e. chrome://extensions). Checks whether the extension is
32 // an ephemeral app. 39 // an ephemeral app.
33 bool ShouldDisplayInExtensionSettings(const Extension* extension, 40 bool ShouldDisplayInExtensionSettings(const Extension* extension,
34 content::BrowserContext* context); 41 content::BrowserContext* context);
35 42
36 // Returns true if the extension should not be shown anywhere. This is 43 // Returns true if the extension should not be shown anywhere. This is
37 // mostly the same as the extension being a component extension, but also 44 // mostly the same as the extension being a component extension, but also
38 // includes non-component apps that are hidden from the app launcher and NTP, 45 // includes non-component apps that are hidden from the app launcher and NTP,
39 // as well as ephemeral apps. 46 // as well as ephemeral apps.
40 bool ShouldNotBeVisible(const Extension* extension, 47 bool ShouldNotBeVisible(const Extension* extension,
41 content::BrowserContext* context); 48 content::BrowserContext* context);
42 49
43 } // namespace ui_util 50 } // namespace ui_util
44 } // namespace extensions 51 } // namespace extensions
45 52
46 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 53 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698