Ensure ephemeral apps have dock icons on mac

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 
 #include "base/command_line.h"
@@ skipping 581 matching lines @@
   // placed under the profile path. For shims, this copy is used when the
   // version under Applications is removed, and not needed for app list because
   // setting LSUIElement means there is no Dock "running" status to show.
   const bool is_app_list = info_.extension_id == app_mode::kAppListModeId;
   if (is_app_list) {
     path_to_add_to_dock = base::SysUTF8ToNSString(
         applications_dir.Append(GetShortcutBasename()).AsUTF8Unsafe());
   } else {
     paths.push_back(app_data_dir_);
   }
-  paths.push_back(applications_dir);
 
+  bool shortcut_visible =
+      creation_locations.applications_menu_location != APP_MENU_LOCATION_HIDDEN;
+  if (shortcut_visible)
+    paths.push_back(applications_dir);
+
+  DCHECK(!paths.empty());
   size_t success_count = CreateShortcutsIn(paths);
   if (success_count == 0)
     return false;
 
   if (!is_app_list)
     UpdateInternalBundleIdentifier();
 
   if (success_count != paths.size())
     return false;
 
-  if (creation_locations.in_quick_launch_bar && path_to_add_to_dock) {
+  if (creation_locations.in_quick_launch_bar && path_to_add_to_dock &&
+      shortcut_visible) {
     switch (dock::AddIcon(path_to_add_to_dock, nil)) {
       case dock::IconAddFailure:
         // If adding the icon failed, instead reveal the Finder window.
         RevealAppShimInFinder();
         break;
       case dock::IconAddSuccess:
       case dock::IconAlreadyPresent:
         break;
     }
     return true;
@@ skipping 382 matching lines @@
   web_app::UpdateShortcutInfoAndIconForApp(
       app,
       profile,
       base::Bind(&web_app::CreateAppShortcutInfoLoaded,
                  profile,
                  app,
                  close_callback));
 }
 
 }  // namespace chrome