Issue 311273003: Mojo: Add resize and push_back to Array.

Issue 311273003: Mojo: Add resize and push_back to Array. (Closed)

Created:
6 years, 6 months ago by Sam McNally

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add resize and push_back to Array. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276336

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : ForwardType #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -0 lines)			Patch
M	mojo/public/cpp/bindings/array.h	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/lib/array_internal.h	View	1 2	4 chunks	+32 lines, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/array_unittest.cc	View	1 2	2 chunks	+228 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

nice tests. LGTM. just one nit: https://codereview.chromium.org/311273003/diff/60001/mojo/public/cpp/bindings/lib/array_internal.h File mojo/public/cpp/bindings/lib/array_internal.h (right): https://codereview.chromium.org/311273003/diff/60001/mojo/public/cpp/bindings/lib/array_internal.h#newcode297 mojo/public/cpp/bindings/lib/array_internal.h:297: static inline void ...

6 years, 6 months ago (2014-06-10 22:33:13 UTC) #2

Sam McNally

https://codereview.chromium.org/311273003/diff/60001/mojo/public/cpp/bindings/lib/array_internal.h File mojo/public/cpp/bindings/lib/array_internal.h (right): https://codereview.chromium.org/311273003/diff/60001/mojo/public/cpp/bindings/lib/array_internal.h#newcode297 mojo/public/cpp/bindings/lib/array_internal.h:297: static inline void PushBack(std::vector<T>* vec, SinkType value) { On ...

6 years, 6 months ago (2014-06-10 23:55:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/311273003/120001

6 years, 6 months ago (2014-06-10 23:57:04 UTC) #5

Message was sent while issue was closed.

Change committed as 276336

Expand Messages | Collapse Messages