Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 311263015: Add dump() to SkClipStack to help with debugging. (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add dump() to SkClipStack to help with debugging. Committed: https://skia.googlesource.com/skia/+/b6b02526438d6839481fb40ccf610d28f7652397

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : Add \n. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -2 lines) Patch
M include/core/SkClipStack.h View 1 3 chunks +19 lines, -0 lines 0 comments Download
M include/core/SkRRect.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M include/core/SkRect.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M include/core/SkRegion.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkClipStack.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRRect.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 6 months ago (2014-06-06 20:58:30 UTC) #1
robertphillips
lgtm + 1 question https://codereview.chromium.org/311263015/diff/20001/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): https://codereview.chromium.org/311263015/diff/20001/src/core/SkClipStack.cpp#newcode882 src/core/SkClipStack.cpp:882: case kEmpty_Type: SkDebugf("\n"); here ?
6 years, 6 months ago (2014-06-08 19:48:31 UTC) #2
bsalomon
https://codereview.chromium.org/311263015/diff/20001/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): https://codereview.chromium.org/311263015/diff/20001/src/core/SkClipStack.cpp#newcode882 src/core/SkClipStack.cpp:882: case kEmpty_Type: On 2014/06/08 19:48:31, robertphillips wrote: > SkDebugf("\n"); ...
6 years, 6 months ago (2014-06-09 13:29:42 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-06-09 14:34:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/311263015/40001
6 years, 6 months ago (2014-06-09 14:35:12 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 14:59:13 UTC) #6
Message was sent while issue was closed. 
Change committed as b6b02526438d6839481fb40ccf610d28f7652397

Powered by Google App Engine
This is Rietveld 408576698