Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 311263014: IndexedDB: Fix trivial cpplint.py errors (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
Reviewers:
ericu, Tom Sepez, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

IndexedDB: Fix trivial cpplint.py errors Classes of errors tackled: whitespace, include-what-you-use, explicit constructors, parameter names, include guards, bracing, and one use of "unsigned long" in IPC. This does not tackle use of non-const references, since those should be carefully reviewed and affects the callers. Also, several uses of "long" remain in content/child when implementing Blink interfaces. R=cmumford@chromium.org,ericu@chromium.org,tsepez@chromium.org BUG=381456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276451

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -68 lines) Patch
M content/browser/indexed_db/indexed_db_active_blob_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_blob_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 3 chunks +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_error.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_pending_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_value.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/mock_indexed_db_callbacks.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/indexed_db/mock_indexed_db_callbacks.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_key_builders.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 5 chunks +1 line, -5 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_path.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
jsbell
cmumford@, ericu@ - please take a look? tsepez@ - OWNERS review of trivial messaging change ...
6 years, 6 months ago (2014-06-06 18:55:03 UTC) #1
Tom Sepez
Messages LGTM. Thanks for the cleanup.
6 years, 6 months ago (2014-06-06 19:05:16 UTC) #2
cmumford
lgtm https://codereview.chromium.org/311263014/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/311263014/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc#newcode165 content/browser/indexed_db/indexed_db_backing_store.cc:165: // TODO(cmumford): Improve test coverage so that all ...
6 years, 6 months ago (2014-06-09 19:17:21 UTC) #3
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-09 19:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/311263014/20001
6 years, 6 months ago (2014-06-09 19:22:33 UTC) #5
ericu
lgtm
6 years, 6 months ago (2014-06-09 19:31:12 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 08:26:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:32:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/40017)
6 years, 6 months ago (2014-06-10 12:32:04 UTC) #9
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-11 16:59:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/311263014/20001
6 years, 6 months ago (2014-06-11 17:00:14 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:08:43 UTC) #12
Message was sent while issue was closed.
Change committed as 276451

Powered by Google App Engine
This is Rietveld 408576698