Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: Source/platform/heap/ThreadState.cpp

Issue 311263008: Make |Heap::findGCInfo()| threadsafe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: move iteration to ThreadState Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 ASSERT(!state->isAtSafePoint()); 884 ASSERT(!state->isAtSafePoint());
885 state->safePoint(HeapPointersOnStack); 885 state->safePoint(HeapPointersOnStack);
886 } 886 }
887 887
888 ThreadState::AttachedThreadStateSet& ThreadState::attachedThreads() 888 ThreadState::AttachedThreadStateSet& ThreadState::attachedThreads()
889 { 889 {
890 DEFINE_STATIC_LOCAL(AttachedThreadStateSet, threads, ()); 890 DEFINE_STATIC_LOCAL(AttachedThreadStateSet, threads, ());
891 return threads; 891 return threads;
892 } 892 }
893 893
894 #if ENABLE(GC_TRACING)
895 const GCInfo* ThreadState::findGCInfoFromAllThreads(Address address)
896 {
897 bool needLockForIteration = !isAnyThreadInGC();
898 if (needLockForIteration)
899 threadAttachMutex().lock();
900
901 ThreadState::AttachedThreadStateSet& threads = attachedThreads();
902 for (ThreadState::AttachedThreadStateSet::iterator it = threads.begin(), end = threads.end(); it != end; ++it) {
903 if (const GCInfo* gcInfo = (*it)->findGCInfo(address)) {
904 if (needLockForIteration)
905 threadAttachMutex().unlock();
906 return gcInfo;
907 }
908 }
909 if (needLockForIteration)
910 threadAttachMutex().unlock();
911 return 0;
894 } 912 }
913 #endif
914 }
OLDNEW
« no previous file with comments | « Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698