Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 311263007: Make DummyPageHolder to have all empty clients (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews
Visibility:
Public.

Description

Make DummyPageHolder to have all empty clients This patch changes DummyPageHolder to use fillWithEmptyClients() instead of making specific empty clients for writing tests depending on client objects not created in current DumpPageHolder class, e.g. spell checker client for editing test. BUG=n/a TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175563

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2014-06-05T17:39:25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/core/testing/DummyPageHolder.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/testing/DummyPageHolder.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
6 years, 6 months ago (2014-06-05 07:43:25 UTC) #1
tkent
https://codereview.chromium.org/311263007/diff/1/Source/core/testing/DummyPageHolder.cpp File Source/core/testing/DummyPageHolder.cpp (right): https://codereview.chromium.org/311263007/diff/1/Source/core/testing/DummyPageHolder.cpp#newcode55 Source/core/testing/DummyPageHolder.cpp:55: m_pageClients.spellCheckerClient = &m_spellCheckerClient; Can you use fillWithEmptyClients()?
6 years, 6 months ago (2014-06-05 07:57:32 UTC) #2
yosin_UTC9
PTAL https://codereview.chromium.org/311263007/diff/1/Source/core/testing/DummyPageHolder.cpp File Source/core/testing/DummyPageHolder.cpp (right): https://codereview.chromium.org/311263007/diff/1/Source/core/testing/DummyPageHolder.cpp#newcode55 Source/core/testing/DummyPageHolder.cpp:55: m_pageClients.spellCheckerClient = &m_spellCheckerClient; On 2014/06/05 07:57:32, tkent wrote: ...
6 years, 6 months ago (2014-06-05 09:04:13 UTC) #3
tkent
lgtm
6 years, 6 months ago (2014-06-05 09:39:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/311263007/20001
6 years, 6 months ago (2014-06-05 09:40:46 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 12:51:39 UTC) #6
Message was sent while issue was closed.
Change committed as 175563

Powered by Google App Engine
This is Rietveld 408576698