Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 311263003: Delete non-CoreAnimation code in RWHVMac (Closed)

Created:
6 years, 6 months ago by ccameron
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@swappressure
Visibility:
Public.

Description

Delete non-CoreAnimation code in RWHVMac This is dead code now, and is just getting in the way. The non-CA code in ui/cocoa may still be useful for reference and debugging for a little longer, but this stuff is way past that point. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275639

Patch Set 1 #

Patch Set 2 : Update driver bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -643 lines) Patch
M content/browser/renderer_host/compositing_iosurface_context_mac.h View 4 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.mm View 5 chunks +34 lines, -95 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_layer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 3 chunks +2 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 5 chunks +1 line, -36 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 33 chunks +61 lines, -462 lines 2 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ccameron
BWAAAAHAHAHHAHAH https://codereview.chromium.org/311263003/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (left): https://codereview.chromium.org/311263003/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#oldcode209 content/browser/renderer_host/render_widget_host_view_mac.mm:209: content::GetCoreAnimationStatus()); I think this DCHECK_EQ was added by ...
6 years, 6 months ago (2014-06-05 03:05:13 UTC) #1
Ken Russell (switch to Gerrit)
Excellent. LGTM https://codereview.chromium.org/311263003/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (left): https://codereview.chromium.org/311263003/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#oldcode209 content/browser/renderer_host/render_widget_host_view_mac.mm:209: content::GetCoreAnimationStatus()); On 2014/06/05 03:05:14, ccameron1 wrote: > ...
6 years, 6 months ago (2014-06-05 17:49:44 UTC) #2
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 6 months ago (2014-06-06 16:44:11 UTC) #3
ccameron
The CQ bit was unchecked by ccameron@chromium.org
6 years, 6 months ago (2014-06-06 16:44:14 UTC) #4
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 6 months ago (2014-06-06 19:23:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/311263003/20001
6 years, 6 months ago (2014-06-06 19:26:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 23:29:53 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:18:51 UTC) #8
Message was sent while issue was closed.
Change committed as 275639

Powered by Google App Engine
This is Rietveld 408576698