Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: sdk/lib/_internal/pub/test/test_pub.dart

Issue 311253005: Bind to all available loopback addresses in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/test_pub.dart
diff --git a/sdk/lib/_internal/pub/test/test_pub.dart b/sdk/lib/_internal/pub/test/test_pub.dart
index bdeebe015758f330c6693467a406b727647ae2c4..a6481e74c03b46739f9cfc4e469fc36cddbcc39f 100644
--- a/sdk/lib/_internal/pub/test/test_pub.dart
+++ b/sdk/lib/_internal/pub/test/test_pub.dart
@@ -170,7 +170,7 @@ void serve([List<d.Descriptor> contents]) {
.catchError((error) {
return new shelf.Response.notFound('File "$path" not found.');
});
- }, '127.0.0.1', 0).then((server) {
+ }, 'localhost', 0).then((server) {
_server = server;
_portCompleter.complete(_server.port);
currentSchedule.onComplete.schedule(_closeServer);
@@ -535,7 +535,7 @@ ScheduledProcess startPub({List args, Future<Uri> tokenEndpoint}) {
// dependencies will look there.
if (_hasServer) {
return port.then((p) {
- environment['PUB_HOSTED_URL'] = "http://127.0.0.1:$p";
+ environment['PUB_HOSTED_URL'] = "http://localhost:$p";
return environment;
});
}
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698