Bind to all available loopback addresses in pub.

sdk/lib/_internal/pub/test/serve/utils.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS d.file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_tests;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 126 matching lines @@
 ///
 /// Unlike [pubServe], this doesn't determine the port number of the server, and
 /// so may be used to test for errors in the initialization process.
 ///
 /// Returns the `pub serve` process.
 ScheduledProcess startPubServe({Iterable<String> args,
     bool createWebDir: true}) {
   var pubArgs = [
     "serve",
     "--port=0", // Use port 0 to get an ephemeral port.
-    "--hostname=127.0.0.1", // Force IPv4 on bots.
+    "--hostname=localhost", // Force IPv4 on bots.

[Bob Nystrom, 2014/06/06 20:22:03]

This can just be removed now, right?

[nweiz, 2014/06/09 20:01:19]

Done.

     "--force-poll",
     "--log-admin-url"
   ];
 
   if (args != null) pubArgs.addAll(args);
 
   // Dart2js can take a long time to compile dart code, so we increase the
   // timeout to cope with that.
   currentSchedule.timeout *= 1.5;
 
@@ skipping 41 matching lines @@
   schedule(() {
     expect(_ports, isNot(isEmpty));
     _portsCompleter.complete();
   });
 
   return _pubServer;
 }
 
 /// The regular expression for parsing pub's output line describing the URL for
 /// the server.
-final _parsePortRegExp = new RegExp(r"([^ ]+) +on http://127\.0\.0\.1:(\d+)");
+final _parsePortRegExp = new RegExp(r"([^ ]+) +on http://localhost:(\d+)");
 
-/// Parses the port number from the "Running admin server on 127.0.0.1:1234"
+/// Parses the port number from the "Running admin server on localhost:1234"
 /// line printed by pub serve.
 bool _parseAdminPort(String line) {
   var match = _parsePortRegExp.firstMatch(line);
   if (match == null) return false;
   _adminPort = int.parse(match[2]);
   return true;
 }
 
-/// Parses the port number from the "Serving blah on 127.0.0.1:1234" line
+/// Parses the port number from the "Serving blah on localhost:1234" line
 /// printed by pub serve.
 bool _parsePort(String line) {
   var match = _parsePortRegExp.firstMatch(line);
   if (match == null) return false;
   _ports[match[1]] = int.parse(match[2]);
   return true;
 }
 
 void endPubServe() {
   _pubServer.kill();
@@ skipping 84 matching lines @@
 /// Schedules opening a web socket connection to the currently running pub
 /// serve.
 Future _ensureWebSocket() {
   // Use the existing one if already connected.
   if (_webSocket != null) return new Future.value();
 
   // Server should already be running.
   expect(_pubServer, isNotNull);
   expect(_adminPort, isNotNull);
 
-  return WebSocket.connect("ws://127.0.0.1:$_adminPort").then((socket) {
+  return WebSocket.connect("ws://localhost:$_adminPort").then((socket) {
     _webSocket = socket;
     // TODO(rnystrom): Works around #13913.
     _webSocketBroadcastStream = _webSocket.map(JSON.decode).asBroadcastStream();
   });
 }
 
 /// Schedules closing the web socket connection to the currently-running pub
 /// serve.
 Future closeWebSocket() {
   schedule(() {
@@ skipping 137 matching lines @@
 }
 
 /// Returns a URL string for the server serving [path] from [root].
 ///
 /// If [root] is omitted, defaults to "web". If [path] is omitted, no path is
 /// included. Unlike [getServerUrl], this should only be called after the ports
 /// are known.
 String _getServerUrlSync([String root, String path]) {
   if (root == null) root = 'web';
   expect(_ports, contains(root));
-  var url = "http://127.0.0.1:${_ports[root]}";
+  var url = "http://localhost:${_ports[root]}";
   if (path != null) url = "$url/$path";
   return url;
 }