Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: cc/trees/layer_tree_host_unittest_delegated.cc

Issue 311253004: Invert DSF to map from delegated frame to layer space (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest_delegated.cc
diff --git a/cc/trees/layer_tree_host_unittest_delegated.cc b/cc/trees/layer_tree_host_unittest_delegated.cc
index abd5e4b1e914d30f606346741517fb5463c0f7bc..57b82b8f8045c512711c61572cb1fbe790394092 100644
--- a/cc/trees/layer_tree_host_unittest_delegated.cc
+++ b/cc/trees/layer_tree_host_unittest_delegated.cc
@@ -487,8 +487,6 @@ class LayerTreeHostDelegatedTestLayerUsesFrameDamage
break;
case 3:
// Should create a total amount of gfx::Rect(2, 2, 10, 6) damage.
danakj 2014/06/06 17:17:12 Add a comment here explaining why 2,2,10,6 becomes
- // The frame size is 20x20 while the layer is 10x10, so this should
- // produce a gfx::Rect(1, 1, 5, 3) damage rect.
SetFrameData(
CreateFrameData(gfx::Rect(0, 0, 20, 20), gfx::Rect(2, 2, 5, 5)));
SetFrameData(
@@ -535,9 +533,7 @@ class LayerTreeHostDelegatedTestLayerUsesFrameDamage
gfx::Rect(4, 4, 1, 1)));
break;
case 13:
- // Should create gfx::Rect(1, 1, 2, 2) of damage. The frame size is
- // 5x5 and the display size is now set to 10x10, so this should result
- // in a gfx::Rect(2, 2, 4, 4) damage rect.
+ // Should create gfx::Rect(1, 1, 2, 2) of damage.
SetFrameData(
CreateFrameData(gfx::Rect(0, 0, 5, 5), gfx::Rect(1, 1, 2, 2)));
break;
@@ -583,6 +579,7 @@ class LayerTreeHostDelegatedTestLayerUsesFrameDamage
// ways.
SetFrameData(
CreateFrameData(gfx::Rect(0, 0, 10, 10), gfx::Rect(3, 3, 1, 1)));
+ break;
}
first_draw_for_source_frame_ = true;
}
@@ -616,7 +613,7 @@ class LayerTreeHostDelegatedTestLayerUsesFrameDamage
EXPECT_EQ(gfx::Rect(10, 10).ToString(), damage_rect.ToString());
break;
case 3:
- EXPECT_EQ(gfx::Rect(1, 1, 5, 3).ToString(), damage_rect.ToString());
+ EXPECT_EQ(gfx::Rect(2, 2, 8, 6).ToString(), damage_rect.ToString());
break;
case 4:
EXPECT_EQ(gfx::Rect().ToString(), damage_rect.ToString());
@@ -646,7 +643,7 @@ class LayerTreeHostDelegatedTestLayerUsesFrameDamage
EXPECT_EQ(gfx::Rect().ToString(), damage_rect.ToString());
break;
case 13:
- EXPECT_EQ(gfx::Rect(2, 2, 4, 4).ToString(), damage_rect.ToString());
+ EXPECT_EQ(gfx::Rect(1, 1, 2, 2).ToString(), damage_rect.ToString());
break;
case 14:
EXPECT_EQ(gfx::Rect().ToString(), damage_rect.ToString());

Powered by Google App Engine
This is Rietveld 408576698