Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 311243006: Fix a C++ violation (Closed)

Created:
6 years, 6 months ago by Jim Stichnoth
Modified:
6 years, 6 months ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Fix a C++ violation. Ice::Inst::NumberSentinel is defined within the Inst class definition: class Inst { ... static const InstNumberT NumberDeleted = -1; static const InstNumberT NumberSentinel = 0; ... }; Under some compilers/options, this causes a link error when passing NumberSentinel as a const T& argument. (Another option would be to move the actual definitions into IceInst.cpp.) BUG= none R=jfb@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ab8242c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/IceCfgNode.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 6 months ago (2014-06-05 14:02:21 UTC) #1
JF
lgtm
6 years, 6 months ago (2014-06-05 14:34:14 UTC) #2
Jim Stichnoth
6 years, 6 months ago (2014-06-05 15:06:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rab8242c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698