Issue 311243003: Make git-freeze bail out if the user has too much untracked data.

Issue 311243003: Make git-freeze bail out if the user has too much untracked data. (Closed)

Created:
6 years, 6 months ago by iannucci

Modified:
4 years, 6 months ago

Reviewers:
Jeffrey Yasskin, agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Description

Make git-freeze bail out if the user has too much untracked data. R=agable@chromium.org, jyasskin@chromium.org BUG=376099

Patch Set 2 : Add docstring, fix 80col #

Patch Set 3 : Unnecessary genexp #

Total comments: 10

Patch Set 4 : Address comments #

Created: 6 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+217 lines, -36 lines)
M	git_common.py	View	8 chunks	+107 lines, -14 lines	0 comments
M	git_map.py	View	2 chunks	+2 lines, -2 lines	0 comments
M	git_rebase_update.py	View	1 chunk	+1 line, -1 line	0 comments
M	git_upstream_diff.py	View	1 chunk	+1 line, -1 line	0 comments
M	man/html/git-freeze.html	View	5 chunks	+16 lines, -3 lines	0 comments
M	man/man1/git-freeze.1	View	5 chunks	+11 lines, -5 lines	0 comments
M	man/src/git-freeze.txt	View	1 chunk	+15 lines, -0 lines	0 comments
M	tests/git_common_test.py	View	5 chunks	+64 lines, -10 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agable

https://codereview.chromium.org/311243003/diff/30001/git_common.py File git_common.py (right): https://codereview.chromium.org/311243003/diff/30001/git_common.py#newcode228 git_common.py:228: def die_if(cond, message, *args): I'd prefer just die(message, *args), ...

6 years, 6 months ago (2014-06-11 21:30:17 UTC) #2

iannucci

6 years, 5 months ago (2014-06-28 18:08:55 UTC) #3

PTAL

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py
File git_common.py (right):

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py#new...
git_common.py:228: def die_if(cond, message, *args):
On 2014/06/11 21:30:16, agable wrote:
> I'd prefer just die(message, *args), and leave the if: control flow in the
> caller.

Done.

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py#new...
git_common.py:252: limit = config_int(key, 20)
On 2014/06/11 21:30:16, agable wrote:
> See comment below. This is super weird -- it looks like you're trying to run
> "git config depot-tools.branch-limit 20".

Done.

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py#new...
git_common.py:280: def config(option, default=None):
On 2014/06/11 21:30:17, agable wrote:
> I find this API weird. "git config key value" *sets* key to that value. Here,
> config(key, value) just gets, and covers errors by return value instead. I
> suppose it makes sense when you're used to get/getattr, but is weird when
you're
> used to git config.

Done.

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py#new...
git_common.py:593: * src is the 'original' name of the file if lstat == 'R', or
On 2014/06/11 21:30:16, agable wrote:
> src is the current name of the file, or the 'original' name if lstat == 'R'.

Done.

https://chromiumcodereview.appspot.com/311243003/diff/30001/git_common.py#new...
git_common.py:627: return dict(parser(tokenizer(run_stream('status', '-z',
bufsize=-1))))
On 2014/06/11 21:30:16, agable wrote:
> Why not use --porcelain and then iterate over readlines()? That's easier than
> having to tokenize on \0 yourself.

Then I have to tokenzie quotes. --porcelain is way worse than splitting on \0.

Expand Messages | Collapse Messages