Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 311233007: ServiceWorker, remove old Cache API implementation to make way for the polyfill. (Closed)

Created:
6 years, 6 months ago by gavinp
Modified:
6 years, 6 months ago
Reviewers:
falken, jkarlin, jsbell
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker, remove old Cache API implementation to make way for the polyfill. R=falken@chromium.org,jkarlin@chromium.org BUG=374822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -104 lines) Patch
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D Source/modules/serviceworkers/Cache.h View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/modules/serviceworkers/Cache.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/modules/serviceworkers/Cache.idl View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gavinp
PTAL.
6 years, 6 months ago (2014-06-05 15:15:13 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-05 18:29:55 UTC) #2
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 6 months ago (2014-06-05 19:19:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/311233007/1
6 years, 6 months ago (2014-06-05 19:20:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 20:54:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 20:54:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14444)
6 years, 6 months ago (2014-06-05 20:54:27 UTC) #7
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-05 22:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/311233007/1
6 years, 6 months ago (2014-06-05 22:06:15 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 23:05:58 UTC) #10
Message was sent while issue was closed.
Change committed as 175596

Powered by Google App Engine
This is Rietveld 408576698