Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 311233003: Sanitizer spring cleaning (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
borenet, mtklein
CC:
skia-review_googlegroups.com, jvanverth1, rmistry
Base URL:
https://skia.googlesource.com/buildbot@master
Visibility:
Public.

Description

Sanitizer spring cleaning - Build ASAN and TSAN with skia_gpu=0. - Update tags to Ubuntu13.10-GCE-NoGPU for ASAN and TSAN bots. - Switch TSAN to Release mode. It'll work better that way. - Remove Valgrind, ASAN, and TSAN builders. They're runtime tools, so just building them won't tell us anything beyond a normal build, especially for Valgrind which doesn't build differently at all. BUG=skia:2640 Committed: https://skia.googlesource.com/buildbot/+/38745fb6d24f8f0f272d8b0d2069a52a29cfb580

Patch Set 1 #

Total comments: 2

Patch Set 2 : import from main file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -8347 lines) Patch
M master/master_builders_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
M master/master_compile_builders_cfg.py View 2 chunks +1 line, -5 lines 0 comments Download
M master/master_fyi_builders_cfg.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M master/slaves.cfg View 4 chunks +2 lines, -5 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-Clang-x86_64-Debug-ASAN View 1 chunk +0 lines, -491 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-Clang-x86_64-Debug-ASAN-Trybot View 1 chunk +0 lines, -549 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-Clang-x86_64-Debug-TSAN View 1 chunk +0 lines, -491 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-Clang-x86_64-Debug-TSAN-Trybot View 1 chunk +0 lines, -549 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Valgrind View 1 chunk +0 lines, -476 lines 0 comments Download
D tools/tests/factory_configuration/expected/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Valgrind-Trybot View 1 chunk +0 lines, -532 lines 0 comments Download
A + tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN View 33 chunks +33 lines, -32 lines 0 comments Download
A + tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot View 34 chunks +34 lines, -33 lines 0 comments Download
A + tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN View 22 chunks +37 lines, -36 lines 0 comments Download
A + tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot View 23 chunks +39 lines, -38 lines 0 comments Download
D tools/tests/factory_configuration/expected/Test-Ubuntu13.10-ShuttleA-HD2000-x86_64-Debug-ASAN View 1 chunk +0 lines, -1643 lines 0 comments Download
D tools/tests/factory_configuration/expected/Test-Ubuntu13.10-ShuttleA-HD2000-x86_64-Debug-ASAN-Trybot View 1 chunk +0 lines, -1701 lines 0 comments Download
D tools/tests/factory_configuration/expected/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN View 1 chunk +0 lines, -852 lines 0 comments Download
D tools/tests/factory_configuration/expected/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN-Trybot View 1 chunk +0 lines, -910 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 6 months ago (2014-06-04 19:09:44 UTC) #1
borenet
LGTM with one comment. We could probably remove several more of the compile bots which ...
6 years, 6 months ago (2014-06-04 19:17:11 UTC) #2
mtklein
Thanks Eric. I'll follow up with a compile bot pruning. You're right, many are redundant, ...
6 years, 6 months ago (2014-06-04 19:36:00 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-04 19:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/311233003/20001
6 years, 6 months ago (2014-06-04 19:37:19 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:37:37 UTC) #6
Message was sent while issue was closed.
Change committed as 38745fb6d24f8f0f272d8b0d2069a52a29cfb580

Powered by Google App Engine
This is Rietveld 408576698