Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 311213002: Update gyp for msvs-ninja. (Closed)

Created:
6 years, 6 months ago by bungeman-skia
Modified:
6 years, 6 months ago
Reviewers:
epoger, borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
With the newest gyp, msvs-ninja should work with Skia.
6 years, 6 months ago (2014-06-04 17:15:59 UTC) #1
epoger
LGTM. Thanks!
6 years, 6 months ago (2014-06-04 17:18:35 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-04 18:22:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/311213002/1
6 years, 6 months ago (2014-06-04 18:23:54 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:35:06 UTC) #5
Message was sent while issue was closed.
Change committed as c3f100b0ffe47c232414ccafd58bf6fe85589832

Powered by Google App Engine
This is Rietveld 408576698