Issue 3112010: [Isolates] Rebase and get d8 to compile....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3112010: [Isolates] Rebase and get d8 to compile.... (Closed)

Created:
10 years, 4 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Rebase and get d8 to compile. More or less the same thing as 3028006. Committed: http://code.google.com/p/v8/source/detail?r=5266

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -17 lines)			Patch
M	src/d8.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	src/d8-debug.h	View	1	4 chunks	+7 lines, -6 lines	0 comments	Download
M	src/d8-debug.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zarko

This one's been on the backburner for a while because of a compile issue in ...

10 years, 4 months ago (2010-08-13 20:46:01 UTC) #1

Dmitry Titov

10 years, 4 months ago (2010-08-13 21:27:38 UTC) #2

LGTM with 2 nits.

http://codereview.chromium.org/3112010/diff/1/3
File src/d8-debug.h (right):

http://codereview.chromium.org/3112010/diff/1/3#newcode56
src/d8-debug.h:56: explicit RemoteDebugger(i::Isolate* isolate, int port)
doesn't have to be 'explicit' any longer.

http://codereview.chromium.org/3112010/diff/1/3#newcode101
src/d8-debug.h:101: explicit ReceiverThread(i::Isolate* isolate, RemoteDebugger*
remote_debugger)
'explicit' too

Expand Messages | Collapse Messages