Issue 311193009: Replace GraphicsContext::setupPaintFor* with const getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311193009: Replace GraphicsContext::setupPaintFor* with const getters. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
Stephen Chennney, f(malita)

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Replace GraphicsContext::setupPaintFor* with const getters. This is simpler, and marginally more efficient (as it avoids setting up the paint in a default state only to immediately overwrite it). GraphicsContext::setupShader is declared but never defined, so its declaration has been removed while here. BUG=381750 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175697

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -34 lines)			Patch
M	Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/platform/fonts/mac/FontMac.cpp	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContext.h	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContext.cpp	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	Source/platform/graphics/StrokeData.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen Chennney

lgtm. I think I just forgot to do this after the paint caching changes.

6 years, 6 months ago (2014-06-06 19:48:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/311193009/20001

6 years, 6 months ago (2014-06-06 19:49:18 UTC) #4

Message was sent while issue was closed.

Change committed as 175697

Expand Messages | Collapse Messages