Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 311193006: Renable WebViewTest.GeolocationAPIEmbedderHasAccessMultipleBridgeIdAllow with fixes. (Closed)

Created:
6 years, 6 months ago by jam
Modified:
6 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, Michael van Ouwerkerk, jam, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Renable WebViewTest.GeolocationAPIEmbedderHasAccessMultipleBridgeIdAllow with fixes. This broke because of https://src.chromium.org/viewvc/blink?view=rev&revision=175404. There were two problems: -GeolocationProviderImpl::OnClientsChanged() was incorrectly resetting position_ even when it was overridden for testing. We didn't notice this before because the blink-side geolocation controller would cache the last position and it would reuse it for the iframe. now that each frame goes to the browser, it became apparent -the test iframe html needed to be non-zero for the same reason as above (now we need to go to the browser for the iframe) BUG=304341 R=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/geolocation/geolocation_access_iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jam
6 years, 6 months ago (2014-06-05 01:44:53 UTC) #1
lazyboy
lgtm
6 years, 6 months ago (2014-06-05 01:52:14 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 6 months ago (2014-06-05 04:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/311193006/1
6 years, 6 months ago (2014-06-05 04:09:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 06:58:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 07:02:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 07:02:28 UTC) #7
Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

Powered by Google App Engine
This is Rietveld 408576698