Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc

Issue 311193005: Add the about_page key to shared_module manifest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc
index 36a9ec50d7c1c28716ef9b456770de0b6d0f368b..19008a100c4877542ee60d0a03bd724688688bb8 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc
@@ -262,7 +262,7 @@ bool AppInfoSummaryPanel::CanShowAppInWebStore() const {
}
// A small summary panel with a list of the app's imported modules, and a link
-// to each of their options pages.
+// to each of their about pages.
class AppInfoImportedModulesPanel : public views::View,
public views::LinkListener {
public:
@@ -344,14 +344,13 @@ AppInfoImportedModulesPanel::AppInfoImportedModulesPanel(
layout->StartRow(0, kModulesListColumnSetId);
layout->AddView(name_label);
- // If this app has an options page, display it as an 'about' link.
- GURL options_page =
- extensions::ManifestURL::GetOptionsPage(imported_module);
- if (options_page != GURL::EmptyGURL()) {
+ // If this app has an about page, display it as an 'about' link.
+ GURL about_page = extensions::ManifestURL::GetAboutPage(imported_module);
+ if (about_page != GURL::EmptyGURL()) {
views::Link* about_link = new views::Link(l10n_util::GetStringUTF16(
IDS_APPLICATION_INFO_IMPORTED_MODULES_ABOUT_LINK_TEXT));
about_link->set_listener(this);
- about_links_[about_link] = options_page;
+ about_links_[about_link] = about_page;
layout->AddView(about_link);
}
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698