Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/manifest_constants.h

Issue 311193005: Add the about_page key to shared_module manifest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Requested fixes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/manifest_url_handler.cc ('K') | « chrome/common/extensions/manifest_url_handler.cc ('k') | extensions/common/manifest_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_constants.h
diff --git a/extensions/common/manifest_constants.h b/extensions/common/manifest_constants.h
index 31142670431256190dd222c76d7440d3739eaa12..8e22a7e59bbeb1bc0fafac302fbf3090ab0598c9 100644
--- a/extensions/common/manifest_constants.h
+++ b/extensions/common/manifest_constants.h
@@ -10,6 +10,7 @@ namespace extensions {
// Keys used in JSON representation of extensions.
namespace manifest_keys {
+extern const char kAboutPage[];
extern const char kAllFrames[];
extern const char kAltKey[];
extern const char kApp[];
@@ -255,6 +256,8 @@ extern const char kChromeVersionTooLow[];
extern const char kDevToolsExperimental[];
extern const char kDisabledByPolicy[];
extern const char kExperimentalFlagRequired[];
+extern const char kInvalidAboutPage[];
benwells 2014/06/11 00:47:29 Nit: alphabetical.
sashab 2014/06/11 05:40:09 Weird, I've done this in the CC file but not here.
+extern const char kInvalidAboutPageExpectRelativePath[];
extern const char kExpectString[];
extern const char kInvalidAllFrames[];
extern const char kInvalidBackground[];
« chrome/common/extensions/manifest_url_handler.cc ('K') | « chrome/common/extensions/manifest_url_handler.cc ('k') | extensions/common/manifest_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698