Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/common/manifest_constants.cc

Issue 311193005: Add the about_page key to shared_module manifest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change the dialog Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index 3422fb16b8f2024061e31fa2c686f4d5649c5ddf..cb090f6bfbcbc5ced0fd1223e50815314cc2ed67 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -8,6 +8,7 @@ namespace extensions {
namespace manifest_keys {
+const char kAboutPage[] = "about_page";
const char kAllFrames[] = "all_frames";
const char kAltKey[] = "altKey";
const char kApp[] = "app";
@@ -269,6 +270,9 @@ const char kExperimentalFlagRequired[] =
"Loading extensions with 'experimental' permission is turned off by "
"default. You can enable 'Experimental Extension APIs' "
"by visiting chrome://flags.";
+const char kInvalidAboutPage[] = "Invalid value for 'about_page'.";
+const char kInvalidAboutPageExpectRelativePath[] =
+ "Invalid value for 'about_page'. Value must be a relative path.";
const char kInvalidAllFrames[] =
"Invalid value for 'content_scripts[*].all_frames'.";
const char kInvalidBackground[] =
« chrome/common/extensions/manifest_url_handler.cc ('K') | « extensions/common/manifest_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698