Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(77)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/manifest_tests/shared_module_about.json
Issue
311193005
:
Add the about_page key to shared_module manifest (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit
Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/app/generated_resources.grd
chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc
chrome/chrome_tests_unit.gypi
chrome/common/extensions/api/_manifest_features.json
chrome/common/extensions/chrome_manifest_handlers.cc
chrome/common/extensions/manifest_tests/extension_manifests_about_unittest.cc
chrome/common/extensions/manifest_url_handler.h
chrome/common/extensions/manifest_url_handler.cc
chrome/test/data/extensions/manifest_tests/shared_module_about.json
chrome/test/data/extensions/manifest_tests/shared_module_about_absolute.json
chrome/test/data/extensions/manifest_tests/shared_module_about_invalid_type.json
extensions/common/manifest_constants.h
extensions/common/manifest_constants.cc
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« chrome/common/extensions/manifest_url_handler.cc
('k') |
chrome/test/data/extensions/manifest_tests/shared_module_about_absolute.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"name": "Test Shared Module",
3
"version": "1",
4
"export": {
5
"resources": ["*"]
6
},
7
"about_page": "about.html"
8
}
OLD
NEW
« no previous file with comments
|
« chrome/common/extensions/manifest_url_handler.cc
('k') |
chrome/test/data/extensions/manifest_tests/shared_module_about_absolute.json »
('j') |
no next file with comments »
Issue 311193005: Add the about_page key to shared_module manifest (Closed)
Created 6 years, 6 months ago by sashab
Modified 6 years, 6 months ago
Reviewers: benwells, Yoyo Zhou
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 18
This is Rietveld
408576698
Chromium Code Reviews
Issue 311193005:
Add the about_page key to shared_module manifest (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src