Add the about_page key to shared_module manifest

chrome/common/extensions/manifest_url_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_
 
 #include <string>
 
 #include "extensions/common/extension.h"
@@ skipping 22 matching lines @@
   // Returns the Update URL for this extension.
   static const GURL& GetUpdateURL(const Extension* extension);
 
   // Returns true if this extension's update URL is the extension gallery.
   static bool UpdatesFromGallery(const Extension* extension);
   static bool UpdatesFromGallery(const base::DictionaryValue* manifest);
 
   // Returns the Options Page for this extension.
   static const GURL& GetOptionsPage(const Extension* extension);
 
+  // Returns the About Page for this extension.
+  static const GURL& GetAboutPage(const Extension* extension);
+
   // Returns the webstore page URL for this extension.
   static const GURL GetDetailsURL(const Extension* extension);
 };
 
 // A structure to hold the chrome URL overrides that may be specified
 // in the manifest of an extension.
 struct URLOverrides : public Extension::ManifestData {
   typedef std::map<const std::string, GURL> URLOverrideMap;
 
   // Define out of line constructor/destructor to please Clang.
@@ skipping 60 matching lines @@
   virtual bool Validate(const Extension* extension,
                         std::string* error,
                         std::vector<InstallWarning>* warnings) const OVERRIDE;
 
  private:
   virtual const std::vector<std::string> Keys() const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(OptionsPageHandler);
 };
 
+// Parses the "options_page" manifest key.
+class AboutPageHandler : public ManifestHandler {
+ public:
+  AboutPageHandler();
+  virtual ~AboutPageHandler();
+
+  virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;
+  virtual bool Validate(const Extension* extension,

[benwells, 2014/06/05 03:59:17]

Do you know what calls this? It is weird that it uses a string resource to
return errors. Normally developer errors aren't translated.

[sashab, 2014/06/10 05:44:13]

Not sure what calls it (there are a lot of callsites - it's a complex path), but
the comment says that it's specifically for validating files associated with the
manifest key exist:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

There's also a TODO on the method that says to change the error to
base::string16, so I'm guessing it's just a bool at the moment because it hasn't
been fixed yet:
// TODO(yoz): Change error to base::string16. See crbug.com/71980.

[Yoyo Zhou, 2014/06/10 11:16:18]

This is principally called from extensions::file_util::ValidateExtension. I
think it may produce user-visible strings if e.g. the extension gets corrupted
on disk.

+                        std::string* error,
+                        std::vector<InstallWarning>* warnings) const OVERRIDE;
+
+ private:
+  virtual const std::vector<std::string> Keys() const OVERRIDE;
+
+  DISALLOW_COPY_AND_ASSIGN(AboutPageHandler);
+};
+
 // Parses the "chrome_url_overrides" manifest key.
 class URLOverridesHandler : public ManifestHandler {
  public:
   URLOverridesHandler();
   virtual ~URLOverridesHandler();
 
   virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;
 
  private:
   virtual const std::vector<std::string> Keys() const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(URLOverridesHandler);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_