Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 311163003: Add mips64 to the makefile. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
hal.canary, djsollen
CC:
skia-review_googlegroups.com, djsollen
Base URL:
https://skia.googlesource.com/skia.git@existingMakefile
Visibility:
Public.

Description

Add mips64 to the makefile. Currently we have no optimizations for mips64, so it correctly contains the various _none.cpps. Corresponds to https://android-review.googlesource.com/#/c/96536/1 Committed: https://skia.googlesource.com/skia/+/9de2fb680f0f09d759fcbedf22f69158fcb84682

Patch Set 1 #

Patch Set 2 : Remove Android.mk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M platform_tools/android/bin/gyp_to_android.py View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
scroggo
6 years, 6 months ago (2014-06-04 21:34:41 UTC) #1
djsollen
lgtm
6 years, 6 months ago (2014-06-05 12:42:33 UTC) #2
hal.canary
LGTM Is this exercised by the android test system?
6 years, 6 months ago (2014-06-05 13:57:43 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-05 17:01:33 UTC) #4
scroggo
On 2014/06/05 13:57:43, Hal Canary wrote: > LGTM > > Is this exercised by the ...
6 years, 6 months ago (2014-06-05 17:02:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/311163003/1
6 years, 6 months ago (2014-06-05 17:02:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 17:02:41 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Android.mk: While running git apply --index -p1; error: Android.mk: does ...
6 years, 6 months ago (2014-06-05 17:02:41 UTC) #8
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-05 17:10:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/311163003/10001
6 years, 6 months ago (2014-06-05 17:11:05 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 17:28:40 UTC) #11
Message was sent while issue was closed.
Change committed as 9de2fb680f0f09d759fcbedf22f69158fcb84682

Powered by Google App Engine
This is Rietveld 408576698