Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 311153002: Remove failing expectations for tests fixed by r175434 (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove failing expectations for tests fixed by r175434 The change to no longer pixel snap for ellipsis (r175434) fixed two ref tests failures on Win7 with DirectWrite. Remove the failing expectation for those tests accordingly. TBR=leviw@chromium.org BUG=378489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eae
6 years, 6 months ago (2014-06-04 14:43:37 UTC) #1
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-04 14:43:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/311153002/1
6 years, 6 months ago (2014-06-04 14:44:24 UTC) #3
leviw_travelin_and_unemployed
LGTM, thanks Emil.
6 years, 6 months ago (2014-06-04 15:58:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 16:32:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:08:10 UTC) #6
Message was sent while issue was closed.
Change committed as 175500

Powered by Google App Engine
This is Rietveld 408576698