Add more Rappor metrics

components/rappor/rappor_utils.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_RAPPOR_RAPPOR_UTILS_H_
+#define COMPONENTS_RAPPOR_RAPPOR_UTILS_H_
+
+#include <string>
+
+class GURL;
+
+namespace rappor {
+
+class RapporService;
+
+// Record the ETLD+1 of a url to a Rappor metric.
+// If the service is NULL, this becomes a no-op.
+void SampleETLDp1FromGURL(RapporService* service,

[Peter Kasting, 2014/06/05 23:37:14]

Please don't abbreviate "plus 1" like this in function names.  If you want to be
consistent with the registry-controlled domain service code, use
"SampleDomainAndRegistryFromHost".  "eTLD+1" isn't a phrase we use in the
codebase.

How come these aren't public static member functions of RapporService?  That
seems like a better place for them; then callers are shielded from knowing that
you're currently instantiating this service as a global on the browser process
(which will help you if this someday turns into a profile keyed service or
something).

[Steven Holte, 2014/06/06 01:54:25]

Done.
Not sure I quite understand this suggestion.  Making a static member function
would effectively just be renaming it to
RapporService::SampleDomainAndRegistryFromGURL.  Are you suggesting also
removing the first member argument and making it take
g_browser_process->rappor_service() internally?  If so, the problem is that
since this code is in components/, it doesn't know that g_browser_process
exists, or what a browser process is.

+                  const std::string& metric,

[Peter Kasting, 2014/06/05 23:37:14]

Nit: Indenting (multiple places)

[Steven Holte, 2014/06/06 01:54:25]

Done.

+                  const GURL& gurl);
+
+// Record the ETLD+1 of a host to a Rappor metric.
+// If the service is NULL, this becomes a no-op.
+void SampleETLDp1FromHost(RapporService* service,
+                  const std::string& metric,
+                  const std::string& host);
+
+}  // namespace rappor
+
+#endif  // COMPONENTS_RAPPOR_RAPPOR_UTILS_H_