chrome/browser/rappor/sampling_unittest.cc - Issue 311133006: Add more Rappor metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/rappor/sampling_unittest.cc

Issue 311133006: Add more Rappor metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove NTP metric Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/rappor/sampling.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8 #include "url/gurl.h"

	9

	10 namespace rappor {

	11

	12 // Make sure recording a sample doesn't cause a crash.
	Peter Kasting 2014/06/09 00:51:14 Nit: Did you mean "recording a sample from an empt Nit: Did you mean "recording a sample from an empty host/GURL"? (As it stands the reader wonders why just "recording a sample" might risk crashing. Or is the Rappor service NULL in tests? If so maybe refer to recording a sample with a NULL service?) Steven Holte 2014/06/09 17:54:29 Done. Show quoted text On 2014/06/09 00:51:14, Peter Kasting wrote: > Nit: Did you mean "recording a sample from an empty host/GURL"? (As it stands > the reader wonders why just "recording a sample" might risk crashing. Or is the > Rappor service NULL in tests? If so maybe refer to recording a sample with a > NULL service?) Done.
	13 TEST(RapporSamplingTest, SmokeTest) {

	14 SampleDomainAndRegistryFromHost(std::string(), std::string());

	15 SampleDomainAndRegistryFromGURL(std::string(), GURL());

	16 }

	17

	18 } // namespace rappor

OLD	NEW