chrome/browser/rappor/sampling.h - Issue 311133006: Add more Rappor metrics

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/rappor/sampling.h

Issue 311133006: Add more Rappor metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove NTP metric Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_RAPPOR_SAMPLING_H_

	6 #define CHROME_BROWSER_RAPPOR_SAMPLING_H_

	7

	8 #include <string>

	9

	10 class GURL;

	11

	12 namespace rappor {

	13

	14 // Record the ETLD+1 of a url to a Rappor metric.
	Peter Kasting 2014/06/09 00:51:14 Nit: Record -> Records (2 places) I would probabl Nit: Record -> Records (2 places) I would probably say "domain and registry" instead of "ETLD+1" to match the function name and the registry-controlled domain service terminology. If you think this is super-unclear, you could perhaps add a parenthetical "(a.k.a. the eTLD+1, "foo.co.uk")" or refer the reader to the RCDS comments for a definition. Steven Holte 2014/06/09 17:54:29 Done. Show quoted text On 2014/06/09 00:51:14, Peter Kasting wrote: > Nit: Record -> Records (2 places) > > I would probably say "domain and registry" instead of "ETLD+1" to match the > function name and the registry-controlled domain service terminology. If you > think this is super-unclear, you could perhaps add a parenthetical "(a.k.a. the > eTLD+1, "foo.co.uk")" or refer the reader to the RCDS comments for a definition. Done.
	15 // If the service is NULL, this becomes a no-op.
	Peter Kasting 2014/06/09 00:51:14 Tiny nit: Minor, but I think this might be a littl Tiny nit: Minor, but I think this might be a little clearer: "If the Rappor service is NULL, this call does nothing." Maybe say when that service might be NULL if any callers would actually care about such a thing. Steven Holte 2014/06/09 17:54:29 Done. Show quoted text On 2014/06/09 00:51:14, Peter Kasting wrote: > Tiny nit: Minor, but I think this might be a little clearer: "If the Rappor > service is NULL, this call does nothing." Maybe say when that service might be > NULL if any callers would actually care about such a thing. Done.
	16 void SampleDomainAndRegistryFromGURL(const std::string& metric,

	17 const GURL& gurl);

	18

	19 // Record the ETLD+1 of a host to a Rappor metric.

	20 // If the service is NULL, this becomes a no-op.

	21 void SampleDomainAndRegistryFromHost(const std::string& metric,

	22 const std::string& host);

	23

	24 } // namespace rappor

	25

	26 #endif // CHROME_BROWSER_RAPPOR_SAMPLING_H_

OLD	NEW

« no previous file with comments | « chrome/browser/rappor/OWNERS ('k') | chrome/browser/rappor/sampling.cc » ('j') | chrome/browser/rappor/sampling_unittest.cc » ('J')