src/arm64/debug-arm64.cc - Issue 311133003: ARM64: Add and use SmiTagAndPush.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/debug-arm64.cc

Issue 311133003: ARM64: Add and use SmiTagAndPush. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/debug-arm64.cc

diff --git a/src/arm64/debug-arm64.cc b/src/arm64/debug-arm64.cc

index b945a6e9d57baec3c824bb56dba100faf66bd408..be2d50275b8cf82c94e255c4f09c52a2f242cc51 100644

--- a/src/arm64/debug-arm64.cc

+++ b/src/arm64/debug-arm64.cc

@@ -157,9 +157,9 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

while (!non_object_list.IsEmpty()) {

// Store each non-object register as two SMIs.

- __ Push(reg);

- __ Poke(wzr, 0);

- __ Push(reg.W(), wzr);

+ __ Lsr(scratch, reg, 32);

+ __ SmiTagAndPush(scratch, reg);

// Stack:

// jssp[12]: reg[63:32]

// jssp[8]: 0x00000000 (SMI tag & padding)

« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »