Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 311123002: Revert "DevTools: matched styles respect :visited/:link pseudo classes" (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 6 months ago
Reviewers:
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert "DevTools: matched styles respect :visited/:link pseudo classes" This reverts commit r174963. Reason for revert: the patch regressed ::content selectors for distributed nodes in shadow DOM. BUG=380414, 356999 TBR=vsevik NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -269 lines) Patch
M LayoutTests/inspector-protocol/css/css-protocol-test.js View 2 chunks +7 lines, -12 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-shadow-host-rule.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-shadow-host-rule-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-visited-link-matched-styles.html View 1 chunk +0 lines, -121 lines 0 comments Download
D LayoutTests/inspector-protocol/css/css-visited-link-matched-styles-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 7 chunks +8 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-04 13:06:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/311123002/1
6 years, 6 months ago (2014-06-04 13:07:28 UTC) #2
lushnikov
6 years, 6 months ago (2014-06-04 13:11:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 14:19:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 14:19:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/13852)
6 years, 6 months ago (2014-06-04 14:19:49 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-04 14:30:30 UTC) #7
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-04 14:30:39 UTC) #8
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-04 14:31:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/311123002/1
6 years, 6 months ago (2014-06-04 14:32:23 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 14:33:44 UTC) #11
Message was sent while issue was closed.
Change committed as 175487

Powered by Google App Engine
This is Rietveld 408576698