Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 311113005: AppModelBuilder to athena. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

AppModelBuilder to athena. AppModelBuilder creates the list of applications in the home card. Right now app_list doesn't have such API, so the interface is in athena. It would be integrated with other app builders eventually. BUG=380421 R=oshima@chromium.org TBR=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276618

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix #

Total comments: 8

Patch Set 3 : fix #

Total comments: 1

Patch Set 4 : fix #

Patch Set 5 : typo #

Patch Set 6 : rebase #

Patch Set 7 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -109 lines) Patch
M athena/activity/public/activity_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M athena/athena.gyp View 1 2 3 4 5 5 chunks +7 lines, -0 lines 0 comments Download
M athena/content/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M athena/content/content_activity_factory.cc View 1 2 3 4 5 6 2 chunks +22 lines, -0 lines 0 comments Download
A athena/content/content_app_model_builder.cc View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
M athena/content/public/content_activity_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
A athena/content/public/content_app_model_builder.h View 1 chunk +32 lines, -0 lines 0 comments Download
M athena/home/app_list_view_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M athena/home/app_list_view_delegate.cc View 3 chunks +3 lines, -93 lines 0 comments Download
M athena/home/home_card_impl.cc View 1 2 3 4 5 5 chunks +10 lines, -6 lines 0 comments Download
A athena/home/public/app_model_builder.h View 1 chunk +29 lines, -0 lines 0 comments Download
M athena/home/public/home_card.h View 1 chunk +3 lines, -2 lines 0 comments Download
M athena/main/athena_launcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M athena/main/athena_launcher.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M athena/main/athena_main.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M athena/test/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M athena/test/athena_test_helper.cc View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M athena/test/sample_activity_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/test/sample_activity_factory.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
A athena/test/test_app_model_builder.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A athena/test/test_app_model_builder.cc View 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-06 22:52:06 UTC) #1
oshima
https://codereview.chromium.org/311113005/diff/1/athena/content/content_activity_factory.cc File athena/content/content_activity_factory.cc (right): https://codereview.chromium.org/311113005/diff/1/athena/content/content_activity_factory.cc#newcode48 athena/content/content_activity_factory.cc:48: DCHECK(!url.is_empty()); how about else LOG(FATAL) << "unknown app id:" ...
6 years, 6 months ago (2014-06-06 23:39:00 UTC) #2
Jun Mukai
https://codereview.chromium.org/311113005/diff/1/athena/content/content_activity_factory.cc File athena/content/content_activity_factory.cc (right): https://codereview.chromium.org/311113005/diff/1/athena/content/content_activity_factory.cc#newcode48 athena/content/content_activity_factory.cc:48: DCHECK(!url.is_empty()); On 2014/06/06 23:39:00, oshima wrote: > how about ...
6 years, 6 months ago (2014-06-09 20:33:13 UTC) #3
oshima
https://codereview.chromium.org/311113005/diff/20001/athena/content/content_app_model_builder.cc File athena/content/content_app_model_builder.cc (right): https://codereview.chromium.org/311113005/diff/20001/athena/content/content_app_model_builder.cc#newcode31 athena/content/content_app_model_builder.cc:31: gfx::ImageSkia GetIcon() const { and you can pass the ...
6 years, 6 months ago (2014-06-09 22:24:38 UTC) #4
Jun Mukai
https://codereview.chromium.org/311113005/diff/20001/athena/content/content_app_model_builder.cc File athena/content/content_app_model_builder.cc (right): https://codereview.chromium.org/311113005/diff/20001/athena/content/content_app_model_builder.cc#newcode31 athena/content/content_app_model_builder.cc:31: gfx::ImageSkia GetIcon() const { On 2014/06/09 22:24:38, oshima wrote: ...
6 years, 6 months ago (2014-06-09 22:35:25 UTC) #5
oshima
lgtm https://codereview.chromium.org/311113005/diff/40001/athena/content/content_app_model_builder.cc File athena/content/content_app_model_builder.cc (right): https://codereview.chromium.org/311113005/diff/40001/athena/content/content_app_model_builder.cc#newcode21 athena/content/content_app_model_builder.cc:21: explicit DummyItem(const std::string& id, remove explicit
6 years, 6 months ago (2014-06-09 22:44:52 UTC) #6
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-10 17:14:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/311113005/60001
6 years, 6 months ago (2014-06-10 17:17:59 UTC) #8
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-11 17:18:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/311113005/100001
6 years, 6 months ago (2014-06-11 17:22:04 UTC) #10
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-11 18:45:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/311113005/120001
6 years, 6 months ago (2014-06-11 18:47:28 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:24:41 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:28:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19628) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15656)
6 years, 6 months ago (2014-06-11 21:28:26 UTC) #15
Jun Mukai
On 2014/06/11 21:28:26, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-11 21:29:49 UTC) #16
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-12 05:31:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/311113005/120001
6 years, 6 months ago (2014-06-12 05:33:52 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 10:32:49 UTC) #19
Message was sent while issue was closed. 
Change committed as 276618

Powered by Google App Engine
This is Rietveld 408576698