Move inspected target events calculation into TracingTimelineModel

Move inspected target events calculation into TracingTimelineModel

BUG=361045
R=caseq@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175482

[yurys, 2014-06-04 12:55:15]

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingModel.js (right):

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingModel.js:198: if (event && event.name
=== WebInspector.TracingModel.DevToolsMetadataEvent.TracingStartedInPage &&
We will need to figure out how to get rid of this dependency. One option would
be to change phase of the devtools metadata events to
WebInspector.TracingModel.Phase.Metadata.

[caseq, 2014-06-04 13:09:00]

lgtm with some nits.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:93:
willStartRecordingTraceEvents: function()
nit: I wonder if we really need this one?

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:99:
didStopRecordingTraceEvents: function()
Can we get it as an event from TracingModel instead of an explicit call from the
top level?

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:110: var endTime =
null;
nit: endTime = Infinity, so that you don't have special case it in comparison
below.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:114: this._mainThread
= event.thread;
Can we rather bind this to processThreadEvents as well?

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:182: while (i <
length && events[i].startTime < startTime)
nit: i = events.upperBound(startTime, function (time, event) { return time <
event.startTime })

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:185: this._eventStack
= [];
unused?

[yurys, 2014-06-04 13:22:16]

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:93:
willStartRecordingTraceEvents: function()
On 2014/06/04 13:08:59, caseq wrote:
> nit: I wonder if we really need this one?

This will be merged with one on TimelineModel eventually.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:99:
didStopRecordingTraceEvents: function()
On 2014/06/04 13:08:59, caseq wrote:
> Can we get it as an event from TracingModel instead of an explicit call from
the
> top level?

I was going to do this in a separate change. TimelineFrameModel also needs to be
updated to use events.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:110: var endTime =
null;
On 2014/06/04 13:08:59, caseq wrote:
> nit: endTime = Infinity, so that you don't have special case it in comparison
> below.

Done.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:114: this._mainThread
= event.thread;
On 2014/06/04 13:08:59, caseq wrote:
> Can we rather bind this to processThreadEvents as well?

Done.

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:182: while (i <
length && events[i].startTime < startTime)
On 2014/06/04 13:08:59, caseq wrote:
> nit: i = events.upperBound(startTime, function (time, event) { return time <
> event.startTime })

Done. Changed to use lowerBound

https://codereview.chromium.org/311113002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:185: this._eventStack
= [];
On 2014/06/04 13:08:59, caseq wrote:
> unused?

It is used. This is to make sure that event stack is empty when we start
processing a new thread.

[yurys, 2014-06-04 13:25:50]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-06-04 13:26:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/311113002/20001

[yurys, 2014-06-04 13:33:31]

Committed patchset #4 manually as r175482 (presubmit successful).