Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Unified Diff: Source/devtools/front_end/ui/TabbedPane.js

Issue 311073002: DevTools: Preserve tab selection in NetworkItemView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/network/NetworkItemView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/TabbedPane.js
diff --git a/Source/devtools/front_end/ui/TabbedPane.js b/Source/devtools/front_end/ui/TabbedPane.js
index 39aebd60213cda869cca2fb52ffc132ebfb9f907..9d41fcb809499ff4dce2f712f6c5152d8075ce5d 100644
--- a/Source/devtools/front_end/ui/TabbedPane.js
+++ b/Source/devtools/front_end/ui/TabbedPane.js
@@ -299,15 +299,16 @@ WebInspector.TabbedPane.prototype = {
/**
* @param {string} id
* @param {boolean=} userGesture
+ * @return {boolean}
*/
selectTab: function(id, userGesture)
{
var focused = this.hasFocus();
var tab = this._tabsById[id];
if (!tab)
- return;
+ return false;
if (this._currentTab && this._currentTab.id === id)
- return;
+ return true;
this._hideCurrentTab();
this._showTab(tab);
@@ -322,6 +323,7 @@ WebInspector.TabbedPane.prototype = {
var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabSelected, eventData);
+ return true;
},
/**
« no previous file with comments | « Source/devtools/front_end/network/NetworkItemView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698