Issue 311063002: Remove D3DCompiler_43.dll from chrome.isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311063002: Remove D3DCompiler_43.dll from chrome.isolate (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit), M-A Ruel

CC:
chromium-reviews, Shannon Woods, nicolascapens, Jamie Madill, Geoff Lang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove D3DCompiler_43.dll from chrome.isolate We used to get this dll from third_party/directxsdk but that's not longer true. For some reason, this started to break bots recently. BUG=none TBR=maruel@chromium.org,kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274724

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/chrome.isolate	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r274724 (tree was closed).

6 years, 6 months ago (2014-06-04 07:18:10 UTC) #2

Ken Russell (switch to Gerrit)

LGTM so long as the GPU bots continue to work. They seem to be doing ...

6 years, 6 months ago (2014-06-04 23:19:41 UTC) #3

M-A Ruel

6 years, 6 months ago (2014-06-04 23:27:47 UTC) #4

Message was sent while issue was closed.

On 2014/06/04 23:19:41, Ken Russell wrote:
> LGTM so long as the GPU bots continue to work. They seem to be doing fine with
> this change.

If Ken approves, I lgtm too.

Expand Messages | Collapse Messages