Issue 311053011: Initialize all ImageCandidate's member variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311053011: Initialize all ImageCandidate's member variables (Closed)

Created:
6 years, 6 months ago by Yoav Weiss

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Initialize all ImageCandidate's member variables While re-reading the code, I noticed that some of ImageCandidate's member variables are not initialized as they should. This CL fixes that. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175758

Patch Set 1 #

Patch Set 2 : Added initialization test #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	Source/core/html/parser/HTMLSrcsetParser.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/html/parser/HTMLSrcsetParserTest.cpp	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yoav Weiss

On 2014/06/07 13:42:59, eseidel (OOO until June 16) wrote: > lgtm > > Please test ...

6 years, 6 months ago (2014-06-08 16:47:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/311053011/20001

6 years, 6 months ago (2014-06-08 16:47:59 UTC) #5

Message was sent while issue was closed.

Change committed as 175758

Expand Messages | Collapse Messages