Source/core/editing/InputMethodController.cpp - Issue 311053008: CANCEL: Make "compositionstart" event cancelable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InputMethodController.cpp

Issue 311053008: CANCEL: Make "compositionstart" event cancelable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2014-06-06T09:53:36 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InputMethodController.cpp

diff --git a/Source/core/editing/InputMethodController.cpp b/Source/core/editing/InputMethodController.cpp

index 3609e75405069a27fc42c957cd5e295daa8802a6..f50dc088a4f953724c8e2fe5acd37c8a47ed1cf5 100644

--- a/Source/core/editing/InputMethodController.cpp

+++ b/Source/core/editing/InputMethodController.cpp

@@ -259,7 +259,9 @@ void InputMethodController::setComposition(const String& text, const Vector<Comp

// We should send a compositionstart event only when the given text is not empty because this

// function doesn't create a composition node when the text is empty.

if (!text.isEmpty()) {

- target->dispatchEvent(CompositionEvent::create(EventTypeNames::compositionstart, m_frame.domWindow(), m_frame.selectedText(), underlines));

+ RefPtrWillBeRawPtr<CompositionEvent> compositionStartEvent = CompositionEvent::create(EventTypeNames::compositionstart, m_frame.domWindow(), m_frame.selectedText(), underlines);

+ if (!target->dispatchEvent(compositionStartEvent))

+ return;

kochi 2014/06/06 05:20:41 You have to dispatch compositionend event for this

event = CompositionEvent::create(EventTypeNames::compositionupdate, m_frame.domWindow(), text, underlines);

}

} else {

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/editing/InputMethodControllerTest.cpp » ('j') | no next file with comments »