Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 311053004: Report precise memory usage from StaticNodeList to v8 (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
haraken, Inactive
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Report precise memory usage from StaticNodeList to v8 BUG=none R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/dom/StaticNodeList.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/StaticNodeList.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-04 11:13:27 UTC) #1
haraken
Won't this regress performance?
6 years, 6 months ago (2014-06-04 11:14:23 UTC) #2
jochen (gone - plz use gerrit)
On 2014/06/04 11:14:23, haraken wrote: > Won't this regress performance? no, not with https://codereview.chromium.org/310393003/ applied. ...
6 years, 6 months ago (2014-06-04 11:54:41 UTC) #3
haraken
On 2014/06/04 11:54:41, jochen wrote: > On 2014/06/04 11:14:23, haraken wrote: > > Won't this ...
6 years, 6 months ago (2014-06-04 12:34:54 UTC) #4
Inactive
lgtm2
6 years, 6 months ago (2014-06-04 13:13:31 UTC) #5
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-10 10:12:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/311053004/1
6 years, 6 months ago (2014-06-10 10:13:13 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 11:17:37 UTC) #8
Message was sent while issue was closed.
Change committed as 175884

Powered by Google App Engine
This is Rietveld 408576698