Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 311053003: Oilpan: update remaining Document uses of RefPtr<Node>s. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: update remaining Document uses of RefPtr<Node>s. Made hoverNode()/setHoveNode() private accessors while converting over remaining PassRefPtr<Node>/RefPtr<Node> uses to transition types. R=tkent@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/dom/Document.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-04 08:01:24 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-04 08:05:25 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-04 08:14:11 UTC) #3
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 08:43:49 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-06-04 08:44:26 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-04 08:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/311053003/1
6 years, 6 months ago (2014-06-04 08:57:46 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:26:12 UTC) #8
Message was sent while issue was closed.
Change committed as 175470

Powered by Google App Engine
This is Rietveld 408576698