Source/core/loader/FormSubmission.h - Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FormSubmission.h

Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed the error when action attribute is empty. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FormSubmission.h

diff --git a/Source/core/loader/FormSubmission.h b/Source/core/loader/FormSubmission.h

index 46fcd82ef8d6e8bd416dadb5ff314000cab8d102..35b5530dc61294a3eeeb6855586f296ef4e82a02 100644

--- a/Source/core/loader/FormSubmission.h

+++ b/Source/core/loader/FormSubmission.h

@@ -67,8 +67,8 @@ public:

void updateMethodType(const String&);

static String methodString(Method);

- const String& action() const { return m_action; }

- void parseAction(const String&);

+ const KURL& action() const { return m_action; }

+ void parseAction(const Document&, const String&);

const AtomicString& target() const { return m_target; }

void setTarget(const AtomicString& target) { m_target = target; }

@@ -87,7 +87,7 @@ public:

Method m_method;

bool m_isMultiPartForm;

- String m_action;

+ KURL m_action;

AtomicString m_target;

AtomicString m_encodingType;

String m_acceptCharset;

« no previous file with comments | « Source/core/html/HTMLFormElement.cpp ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »