Source/core/html/HTMLFormElement.h - Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed reviewers comments and fixed formatting. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-allowed-expected.txt ('K') | « LayoutTests/http/tests/security/originHeader/resources/origin-header-post-to-http.html ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | Source/core/html/HTMLFormElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index d0db27f98514b7c8216f5a0b2486d84fbe103094..1ba399ddb1f333ff8a6eba1a2ff46f3de0dae801 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -118,6 +118,9 @@ public:

void anonymousNamedGetter(const AtomicString& name, bool&, RefPtrWillBeRawPtr<RadioNodeList>&, bool&, RefPtrWillBeRawPtr<Element>&);

+protected:

+ virtual void attributeChanged(const QualifiedName&, const AtomicString&, AttributeModificationReason = ModifiedDirectly) OVERRIDE;

private:

explicit HTMLFormElement(Document&);

@@ -181,7 +184,12 @@ private:

bool m_wasDemoted;

+ bool m_insecureSubmissionReported;

OwnPtr<GenericEventQueue> m_pendingAutocompleteEventsQueue;

+ KURL getActionURL() const {

+ return document().completeURL(m_attributes.action().isEmpty() ? document().url().string() : m_attributes.action()); }

};

} // namespace WebCore