Implementing mixed content for forms posting to insecure location from secure ones

Source/core/loader/FormSubmission.cpp

Index: Source/core/loader/FormSubmission.cpp
diff --git a/Source/core/loader/FormSubmission.cpp b/Source/core/loader/FormSubmission.cpp
index 283b54c19f6819f3b71f61b1b3b3f151780c8fd3..7c5cd462e71d4c3ef7b8b8ad456ee80db49c09be 100644
--- a/Source/core/loader/FormSubmission.cpp
+++ b/Source/core/loader/FormSubmission.cpp
@@ -83,10 +83,9 @@ static void appendMailtoPostFormDataToURL(KURL& url, const FormData& data, const
     url.setQuery(query.toString());
 }
 
-void FormSubmission::Attributes::parseAction(const String& action)
+void FormSubmission::Attributes::parseAction(const Document& document, const String& action)
 {
-    // FIXME: Can we parse into a KURL?
-    m_action = stripLeadingAndTrailingHTMLSpaces(action);
+    m_action = document.completeURL(stripLeadingAndTrailingHTMLSpaces(action));
 }
 
 AtomicString FormSubmission::Attributes::parseEncodingType(const String& type)
@@ -180,7 +179,7 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A
     if (submitButton) {
         AtomicString attributeValue;
         if (!(attributeValue = submitButton->fastGetAttribute(formactionAttr)).isNull())
-            copiedAttributes.parseAction(attributeValue);
+            copiedAttributes.parseAction(form->document(), attributeValue);
         if (!(attributeValue = submitButton->fastGetAttribute(formenctypeAttr)).isNull())
             copiedAttributes.updateEncodingType(attributeValue);
         if (!(attributeValue = submitButton->fastGetAttribute(formmethodAttr)).isNull())
@@ -196,7 +195,7 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A
     }
 
     Document& document = form->document();
-    KURL actionURL = document.completeURL(copiedAttributes.action().isEmpty() ? document.url().string() : copiedAttributes.action());
+    KURL actionURL = (copiedAttributes.action().isEmpty() ? document.url() : copiedAttributes.action());

[abarth-chromium, 2014/06/09 22:06:23]

There's no need for ( ) around the ? :

[mhm, 2014/06/09 23:27:59]

Done.

     bool isMailtoForm = actionURL.protocolIs("mailto");
     bool isMultiPartForm = false;
     AtomicString encodingType = copiedAttributes.encodingType();